Improve the performance of `Obj.getType()` by caching `Obj`'s type by jjppp · Pull Request #205 · pascal-lab/Tai-e

jjppp · 2025-09-06T16:13:47Z

For huge programs such as columba-1.4 from java-benchmarks, most of the analysis time is spent on TypeFilter when propagating objects through the PFG, among which a major proportion is spent on the Obj.getType().

Simply caching the type of the Obj using a field brings substantial speedup to the original Tai-e (comparing 8504562 to 064801b). On my laptop (AMD Ryzen7 4800H 2.9GHz with 16G heap memory for JVM) this optimization saves 30% of the analysis time for columba-1.4.

Tai-e/src/main/java/pascal/taie/analysis/pta/core/heap/Obj.java

Lines 36 to 44 in 8504562

    
           public abstract class Obj implements Indexable { 
        
               protected final Type type; 
        
               private int index = -1; 
        
               protected Obj(Type type) { 
        
                   this.type = type; 
        
               }

The results are shown below (irrelevant lines are removed for clarity):

15c15
< Tai-e Commit: c2c9ebebc65724f79f38732976d58d10b2939a95
---
> Tai-e Commit: 064801b610f49b5ae90ea6e4addf61c415c68386
48c48
< [Pointer analysis] elapsed time: 178.86s
---
> [Pointer analysis] elapsed time: 253.08s
73c73
< pta finishes, elapsed time: 200.34s
---
> pta finishes, elapsed time: 272.84s
77c77
< may-fail-cast finishes, elapsed time: 0.09s
---
> may-fail-cast finishes, elapsed time: 0.10s
81,82c81,82
< poly-call finishes, elapsed time: 0.10s
< Tai-e finishes, elapsed time: 205.03s
---
> poly-call finishes, elapsed time: 0.09s
> Tai-e finishes, elapsed time: 279.17s

log file for gettype optimization(8504562)

Analyzing columba-1.4
Tai-e starts ...
Output directory: /home/jjppp/Code/Project/Tai-e/output
Writing options to /home/jjppp/Code/Project/Tai-e/output/options.yml
Writing log to /home/jjppp/Code/Project/Tai-e/output/tai-e.log
java.version: 17.0.14
java.version.date: 2025-01-21
java.runtime.version: 17.0.14+7-LTS
java.vendor: Amazon.com Inc.
java.vendor.version: Corretto-17.0.14.7.1
os.name: Linux
os.version: 6.15.7-arch1-1
os.arch: amd64
Tai-e Version: 0.5.2-SNAPSHOT
Tai-e Commit: 064801b610f49b5ae90ea6e4addf61c415c68386
Writing analysis plan to /home/jjppp/Code/Project/Tai-e/output/tai-e-plan.yml
WorldBuilder starts ...
The world cache mode is enabled.
Loading the world cache from /home/jjppp/Code/Project/Tai-e/cache/world-cache-2032021125.bin
[Load the world cache] elapsed time: 5.94s
12404 classes with 115918 methods in the world
WorldBuilder finishes, elapsed time: 5.95s
pta starts ...
Using reflection log from /home/jjppp/Code/Project/Tai-e/java-benchmarks/columba/1.4/refl.log
Reflective target 'byte[]' for Class.forName is not found
Reflective target 'java.lang.String[]' for Class.forName is not found
Reflective caller class 'sun.nio.cs.AbstractCharsetProvider' is absent
Reflective target 'sun.security.pkcs.SignerInfo[]' for Class.forName is not found
Reflective target '<com.sun.crypto.provider.BlowfishCipher: void <init>()>' for Constructor.newInstance is not found
Reflective target '<com.sun.crypto.provider.SunJCE: void <init>()>' for Constructor.newInstance is not found
Reflective target '<sun.nio.cs.ext.Big5: void <init>()>' for Constructor.newInstance is not found
Reflective target '<sun.nio.cs.ext.Big5_HKSCS: void <init>()>' for Constructor.newInstance is not found
Reflective target '<sun.nio.cs.ext.EUC_CN: void <init>()>' for Constructor.newInstance is not found
Reflective target '<sun.nio.cs.ext.EUC_JP: void <init>()>' for Constructor.newInstance is not found
Reflective target '<sun.nio.cs.ext.EUC_KR: void <init>()>' for Constructor.newInstance is not found
Reflective target '<sun.nio.cs.ext.EUC_TW: void <init>()>' for Constructor.newInstance is not found
Reflective target '<sun.nio.cs.ext.ExtendedCharsets: void <init>()>' for Constructor.newInstance is not found
Reflective target '<sun.nio.cs.ext.GB18030: void <init>()>' for Constructor.newInstance is not found
Reflective target '<sun.nio.cs.ext.GBK: void <init>()>' for Constructor.newInstance is not found
Reflective target '<sun.nio.cs.ext.ISO2022_JP: void <init>()>' for Constructor.newInstance is not found
Reflective target '<sun.nio.cs.ext.ISO2022_KR: void <init>()>' for Constructor.newInstance is not found
Reflective target '<sun.nio.cs.ext.ISO_8859_3: void <init>()>' for Constructor.newInstance is not found
Reflective target '<sun.nio.cs.ext.Johab: void <init>()>' for Constructor.newInstance is not found
Reflective target '<sun.nio.cs.ext.MS1258: void <init>()>' for Constructor.newInstance is not found
Reflective target '<sun.nio.cs.ext.MS932: void <init>()>' for Constructor.newInstance is not found
Reflective target '<sun.nio.cs.ext.SJIS: void <init>()>' for Constructor.newInstance is not found
Reflective target '<sun.nio.cs.ext.TIS_620: void <init>()>' for Constructor.newInstance is not found
[Pointer analysis] elapsed time: 253.08s
Imprecise reflective calls:
[Array.newInstance]<org.codehaus.groovy.ast.ClassNode: org.codehaus.groovy.ast.ClassNode makeArray()>[9@L143] $r5 = invokestatic java.lang.reflect.Array.newInstance($r4, %intconst0), #targets: 2925
[Array.newInstance]<org.codehaus.groovy.runtime.MetaClassHelper: java.lang.Object makeArray(java.lang.Object,java.lang.Class,int)>[3@L644] $r2 = invokestatic java.lang.reflect.Array.newInstance(r3, length), #targets: 2925
[Class.newInstance]<java.awt.Toolkit: void loadAssistiveTechnologies()>[15@L771] invokevirtual r31.newInstance(), #targets: 1066
[Class.newInstance]<java.beans.Introspector: java.lang.Object instantiate(java.lang.Class,java.lang.String)>[9@L1460] $r9 = invokevirtual $r8.newInstance(), #targets: 1066
[Class.newInstance]<java.beans.Introspector: java.lang.Object instantiate(java.lang.Class,java.lang.String)>[16@L1471] $r7 = invokevirtual $r6.newInstance(), #targets: 1066
[Class.newInstance]<java.security.Provider$Service: java.lang.Object newInstanceGeneric(java.lang.Object)>[2@L1283] $r19 = invokevirtual $r1.newInstance(), #targets: 1066
[Class.newInstance]<java.util.logging.LogManager: void readConfiguration()>[6@L939] invokevirtual $r10.newInstance(), #targets: 1066
[Class.newInstance]<java.util.logging.LogManager: void readConfiguration()>[12@L943] invokevirtual $r27.newInstance(), #targets: 1066
[Class.newInstance]<java.util.logging.LogManager: void readConfiguration(java.io.InputStream)>[12@L1084] invokevirtual $r7.newInstance(), #targets: 1066
[Class.newInstance]<javax.xml.transform.FactoryFinder: java.lang.Object newInstance(java.lang.String,java.lang.ClassLoader,boolean,boolean)>[6@L166] r24 = invokevirtual $r2.newInstance(), #targets: 1066
[Class.newInstance]<org.columba.core.plugin.ExternalClassLoader: java.lang.Object instanciate(java.lang.String,java.lang.Object[])>[5@L-1] $r4 = invokevirtual $r2.newInstance(), #targets: 1066
[Class.newInstance]<org.python.core.PyBeanEventProperty: java.lang.Object getAdapter(java.lang.Object)>[7@L80] $r7 = invokevirtual $r6.newInstance(), #targets: 1066
[Class.newInstance]<org.xml.sax.helpers.NewInstance: java.lang.Object newInstance(java.lang.ClassLoader,java.lang.String)>[14@L60] $r3 = invokevirtual r4.newInstance(), #targets: 1066
-------------- Pointer analysis statistics: --------------
#var pointers:                38,2894 (insens) / 38,2894 (sens)
#objects:                     5,1227 (insens) / 5,1227 (sens)
#var points-to:               1,6755,1378 (insens) / 1,6755,1378 (sens)
#static field points-to:      5,4480 (sens)
#instance field points-to:    1,1034,9431 (sens)
#array points-to:             277,0268 (sens)
#reachable methods:           5,6594 (insens) / 5,6594 (sens)
#call graph edges:            42,5921 (insens) / 42,5921 (sens)
----------------------------------------
pta finishes, elapsed time: 272.84s
may-fail-cast starts ...
#may-fail-cast: found 10406 in 35697 reachable relevant Stmts
#may-fail-cast: found 4377 in 9886 reachable relevant Stmts (app)
may-fail-cast finishes, elapsed time: 0.10s
poly-call starts ...
#poly-call: found 17608 in 167606 reachable relevant Stmts
#poly-call: found 6550 in 72806 reachable relevant Stmts (app)
poly-call finishes, elapsed time: 0.09s
Tai-e finishes, elapsed time: 279.17s

log file for master(064801b)

Analyzing columba-1.4
Tai-e starts ...
Output directory: /home/jjppp/Code/Project/Tai-e/output
Writing options to /home/jjppp/Code/Project/Tai-e/output/options.yml
Writing log to /home/jjppp/Code/Project/Tai-e/output/tai-e.log
java.version: 17.0.14
java.version.date: 2025-01-21
java.runtime.version: 17.0.14+7-LTS
java.vendor: Amazon.com Inc.
java.vendor.version: Corretto-17.0.14.7.1
os.name: Linux
os.version: 6.15.7-arch1-1
os.arch: amd64
Tai-e Version: 0.5.2-SNAPSHOT
Tai-e Commit: c2c9ebebc65724f79f38732976d58d10b2939a95
Writing analysis plan to /home/jjppp/Code/Project/Tai-e/output/tai-e-plan.yml
WorldBuilder starts ...
The world cache mode is enabled.
Loading the world cache from /home/jjppp/Code/Project/Tai-e/cache/world-cache-2032021125.bin
[Load the world cache] elapsed time: 4.33s
12404 classes with 115918 methods in the world
WorldBuilder finishes, elapsed time: 4.34s
pta starts ...
Using reflection log from /home/jjppp/Code/Project/Tai-e/java-benchmarks/columba/1.4/refl.log
Reflective target 'byte[]' for Class.forName is not found
Reflective target 'java.lang.String[]' for Class.forName is not found
Reflective caller class 'sun.nio.cs.AbstractCharsetProvider' is absent
Reflective target 'sun.security.pkcs.SignerInfo[]' for Class.forName is not found
Reflective target '<com.sun.crypto.provider.BlowfishCipher: void <init>()>' for Constructor.newInstance is not found
Reflective target '<com.sun.crypto.provider.SunJCE: void <init>()>' for Constructor.newInstance is not found
Reflective target '<sun.nio.cs.ext.Big5: void <init>()>' for Constructor.newInstance is not found
Reflective target '<sun.nio.cs.ext.Big5_HKSCS: void <init>()>' for Constructor.newInstance is not found
Reflective target '<sun.nio.cs.ext.EUC_CN: void <init>()>' for Constructor.newInstance is not found
Reflective target '<sun.nio.cs.ext.EUC_JP: void <init>()>' for Constructor.newInstance is not found
Reflective target '<sun.nio.cs.ext.EUC_KR: void <init>()>' for Constructor.newInstance is not found
Reflective target '<sun.nio.cs.ext.EUC_TW: void <init>()>' for Constructor.newInstance is not found
Reflective target '<sun.nio.cs.ext.ExtendedCharsets: void <init>()>' for Constructor.newInstance is not found
Reflective target '<sun.nio.cs.ext.GB18030: void <init>()>' for Constructor.newInstance is not found
Reflective target '<sun.nio.cs.ext.GBK: void <init>()>' for Constructor.newInstance is not found
Reflective target '<sun.nio.cs.ext.ISO2022_JP: void <init>()>' for Constructor.newInstance is not found
Reflective target '<sun.nio.cs.ext.ISO2022_KR: void <init>()>' for Constructor.newInstance is not found
Reflective target '<sun.nio.cs.ext.ISO_8859_3: void <init>()>' for Constructor.newInstance is not found
Reflective target '<sun.nio.cs.ext.Johab: void <init>()>' for Constructor.newInstance is not found
Reflective target '<sun.nio.cs.ext.MS1258: void <init>()>' for Constructor.newInstance is not found
Reflective target '<sun.nio.cs.ext.MS932: void <init>()>' for Constructor.newInstance is not found
Reflective target '<sun.nio.cs.ext.SJIS: void <init>()>' for Constructor.newInstance is not found
Reflective target '<sun.nio.cs.ext.TIS_620: void <init>()>' for Constructor.newInstance is not found
[Pointer analysis] elapsed time: 178.86s
Imprecise reflective calls:
[Array.newInstance]<org.codehaus.groovy.ast.ClassNode: org.codehaus.groovy.ast.ClassNode makeArray()>[9@L143] $r5 = invokestatic java.lang.reflect.Array.newInstance($r4, %intconst0), #targets: 2925
[Array.newInstance]<org.codehaus.groovy.runtime.MetaClassHelper: java.lang.Object makeArray(java.lang.Object,java.lang.Class,int)>[3@L644] $r2 = invokestatic java.lang.reflect.Array.newInstance(r3, length), #targets: 2925
[Class.newInstance]<java.awt.Toolkit: void loadAssistiveTechnologies()>[15@L771] invokevirtual r31.newInstance(), #targets: 1066
[Class.newInstance]<java.beans.Introspector: java.lang.Object instantiate(java.lang.Class,java.lang.String)>[9@L1460] $r9 = invokevirtual $r8.newInstance(), #targets: 1066
[Class.newInstance]<java.beans.Introspector: java.lang.Object instantiate(java.lang.Class,java.lang.String)>[16@L1471] $r7 = invokevirtual $r6.newInstance(), #targets: 1066
[Class.newInstance]<java.security.Provider$Service: java.lang.Object newInstanceGeneric(java.lang.Object)>[2@L1283] $r19 = invokevirtual $r1.newInstance(), #targets: 1066
[Class.newInstance]<java.util.logging.LogManager: void readConfiguration()>[6@L939] invokevirtual $r10.newInstance(), #targets: 1066
[Class.newInstance]<java.util.logging.LogManager: void readConfiguration()>[12@L943] invokevirtual $r27.newInstance(), #targets: 1066
[Class.newInstance]<java.util.logging.LogManager: void readConfiguration(java.io.InputStream)>[12@L1084] invokevirtual $r7.newInstance(), #targets: 1066
[Class.newInstance]<javax.xml.transform.FactoryFinder: java.lang.Object newInstance(java.lang.String,java.lang.ClassLoader,boolean,boolean)>[6@L166] r24 = invokevirtual $r2.newInstance(), #targets: 1066
[Class.newInstance]<org.columba.core.plugin.ExternalClassLoader: java.lang.Object instanciate(java.lang.String,java.lang.Object[])>[5@L-1] $r4 = invokevirtual $r2.newInstance(), #targets: 1066
[Class.newInstance]<org.python.core.PyBeanEventProperty: java.lang.Object getAdapter(java.lang.Object)>[7@L80] $r7 = invokevirtual $r6.newInstance(), #targets: 1066
[Class.newInstance]<org.xml.sax.helpers.NewInstance: java.lang.Object newInstance(java.lang.ClassLoader,java.lang.String)>[14@L60] $r3 = invokevirtual r4.newInstance(), #targets: 1066
-------------- Pointer analysis statistics: --------------
#var pointers:                38,2894 (insens) / 38,2894 (sens)
#objects:                     5,1227 (insens) / 5,1227 (sens)
#var points-to:               1,6755,1378 (insens) / 1,6755,1378 (sens)
#static field points-to:      5,4480 (sens)
#instance field points-to:    1,1034,9431 (sens)
#array points-to:             277,0268 (sens)
#reachable methods:           5,6594 (insens) / 5,6594 (sens)
#call graph edges:            42,5921 (insens) / 42,5921 (sens)
----------------------------------------
pta finishes, elapsed time: 200.34s
may-fail-cast starts ...
#may-fail-cast: found 10406 in 35697 reachable relevant Stmts
#may-fail-cast: found 4377 in 9886 reachable relevant Stmts (app)
may-fail-cast finishes, elapsed time: 0.09s
poly-call starts ...
#poly-call: found 17608 in 167606 reachable relevant Stmts
#poly-call: found 6550 in 72806 reachable relevant Stmts (app)
poly-call finishes, elapsed time: 0.10s
Tai-e finishes, elapsed time: 205.03s

codecov · 2025-09-06T16:40:58Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.82%. Comparing base (dee2f45) to head (247f571).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files

@@             Coverage Diff              @@
##             master     #205      +/-   ##
============================================
- Coverage     75.82%   75.82%   -0.01%     
+ Complexity     4658     4655       -3     
============================================
  Files           481      481              
  Lines         16070    16067       -3     
  Branches       2199     2199              
============================================
- Hits          12185    12182       -3     
  Misses         3018     3018              
  Partials        867      867

Files with missing lines	Coverage Δ
...ascal/taie/analysis/pta/core/heap/ConstantObj.java	`100.00% <100.00%> (ø)`
.../pascal/taie/analysis/pta/core/heap/MergedObj.java	`76.47% <100.00%> (-2.48%)`	⬇️
...va/pascal/taie/analysis/pta/core/heap/MockObj.java	`89.28% <100.00%> (-0.72%)`	⬇️
...ava/pascal/taie/analysis/pta/core/heap/NewObj.java	`100.00% <100.00%> (ø)`
...n/java/pascal/taie/analysis/pta/core/heap/Obj.java	`69.23% <100.00%> (+9.23%)`	⬆️

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

zhangt2333

Amazing optimization! Let's see what @silverbullettt thinks.

jjppp force-pushed the gettype branch from 8504562 to d89fc5f Compare September 7, 2025 09:28

zhangt2333 approved these changes Sep 8, 2025

View reviewed changes

Add a field for Obj's type

247f571

jjppp force-pushed the gettype branch from d89fc5f to 247f571 Compare November 1, 2025 10:06

silverbullettt merged commit 5dc8ae3 into pascal-lab:master Dec 5, 2025
5 checks passed

github-actions bot locked and limited conversation to collaborators Dec 5, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Improve the performance of `Obj.getType()` by caching `Obj`'s type#205

Improve the performance of `Obj.getType()` by caching `Obj`'s type#205
silverbullettt merged 1 commit intopascal-lab:masterfrom
jjppp:gettype

jjppp commented Sep 6, 2025

Uh oh!

codecov bot commented Sep 6, 2025 •

edited

Loading

Uh oh!

zhangt2333 left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	public abstract class Obj implements Indexable {

	protected final Type type;

	private int index = -1;

	protected Obj(Type type) {
	this.type = type;
	}

Conversation

jjppp commented Sep 6, 2025

Uh oh!

codecov bot commented Sep 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

zhangt2333 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

codecov bot commented Sep 6, 2025 •

edited

Loading